Wireshark-bugs: [Wireshark-bugs] [Bug 11321] Need a dissector for windows search protocol MS-WSP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 01 Jul 2015 09:59:13 +0000

Comment # 4 on bug 11321 from 
Created attachment 13699 [details]
patch set for implementation of MS-WSP protocol dissector

here is a squashed patch set, still there are 11 interdependent patches, I
guess the first 2 patches are you could say completely independent [1]  and the
second 2 are functionally independent but following patches will not compile
without them.


[1] afaik the dissector will compile and run without them but they give extra
information (e.g. about operations on the pipe the protocol uses)

I am not sure what is the best way to proceed with these with gerrit, should I
just push the patches in the topic branch to gerrit e.g.

git push origin HEAD:refs/for/master/MSWSP-dissector (or something like that)

if my last experience is to go by it will result in some patches that will not
merge (because they seem to be treated independently but still marked as
related)

not sure what I should do, any advice

You are receiving this mail because:
  • You are watching all bug changes.