Wireshark-bugs: [Wireshark-bugs] [Bug 11322] Regression: TCP reassembly can fail DISSECTOR_ASSER
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 30 Jun 2015 20:32:07 +0000

Comment # 10 on bug 11322 from 
(In reply to Hadriel Kaplan from comment #8)
> So looking at some other dissectors, it looks like they should just return
> the whole packet's length (i.e., tvb_captured_length()) - and only return 0
> if the packet's not for them at all.
> 
> So maybe what I should do is change the dissect_lua() function in
> init_wslua.c to do that if the Lua dissector set the desegment_len/offset
> but returned 0.
> 
> That way I'd keep backwards-compatibility, but let the packet-tcp.c continue
> to do the asssert checks.
> 
> Thoughts?

That still sounds as a hack to me, but I do not have any strong opinion. Given
the comments found in packet.h for dissector_try_uint_new(), returning 0 still
seems incorrect.

You are receiving this mail because:
  • You are watching all bug changes.