Wireshark-bugs: [Wireshark-bugs] [Bug 11229] New: The HTTP dissector doesn't support the PATCH m
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 27 May 2015 16:29:14 +0000
Bug ID 11229
Summary The HTTP dissector doesn't support the PATCH method
Product Wireshark
Version 1.12.5
Hardware x86
OS Windows 7
Status UNCONFIRMED
Severity Minor
Priority Low
Component Dissection engine (libwireshark)
Assignee bugzilla-admin@wireshark.org
Reporter Andy.Ling@quantel.com 

Build Information:
Version 1.12.5 (Git Rev Unknown from unknown)

Copyright 1998-2015 Gerald Combs <gerald@wireshark.org> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GTK+ 2.24.23, with Cairo 1.10.2, with Pango 1.34.0, with
GLib 2.38.0, with WinPcap (4_1_3), with libz 1.2.5, with SMI 0.4.8, with c-ares
1.9.1, with Lua 5.2, without Python, with GnuTLS 3.2.15, with Gcrypt 1.6.2,
with
MIT Kerberos, with GeoIP, with PortAudio V19-devel (built May 26 2015), with
AirPcap.

Running on 64-bit Windows 7 Service Pack 1, build 7601, with WinPcap version
4.1.3 (packet.dll version 4.1.0.2980), based on libpcap version 1.0 branch
1_0_rel0b (20091008), GnuTLS 3.2.15, Gcrypt 1.6.2, without AirPcap.
Intel(R) Core(TM)2 Quad CPU    Q6700  @ 2.66GHz, with 8061MB of physical
memory.


Built using Microsoft Visual C++ 12.0 build 31101

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
The HTTP dissector doesn't understand the PATCH http request method. Whilst
this isn't a very common method, it does still seem to be valid and there are
lots of other rather obscure methods listed in the dissector.

It seems to be a trivial fix to change packet-http.c so that
is_http_request_or_reply has the following at line 2136..

        case 5:
            if (strncmp(data, "BCOPY", indx) == 0 ||
                strncmp(data, "BMOVE", indx) == 0 ||
                strncmp(data, "MKCOL", indx) == 0 ||
                strncmp(data, "TRACE", indx) == 0 ||
                strncmp(data, "PATCH", indx) == 0 ||
                strncmp(data, "LABEL", indx) == 0 ||  /* RFC 3253 8.2 */
                strncmp(data, "MERGE", indx) == 0) {  /* RFC 3253 11.2 */
                *type = HTTP_REQUEST;
                isHttpRequestOrReply = TRUE;
            }
            break;

You are receiving this mail because:
  • You are watching all bug changes.