Wireshark-bugs: [Wireshark-bugs] [Bug 11134] CORBA dissectors show malformed packet errors for v
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 21 Apr 2015 16:14:09 +0000

Comment # 2 on bug 11134 from 
It's not the dissector or idl2wrs that need changing. They call
proto_tree_add_item which is part of the released code base in proto.c

proto_tree_add_item in tern calls get_hfi_length, which is the function at
fault. Also part of the released code.

As I said, changing get_hfi_length to call tvb_captured_length_remaining fixes
the problem, but I don't know enough about the code to know if this is the
right way to fix the problem.

I think both comments are correct, tvb_ensure_captured_length_remaining does
ensure the length is greater than zero and get_hfi_length does want to allow a
zero length, it's just that it doesn't.

You are receiving this mail because:
  • You are watching all bug changes.