Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 11051] New: Support gtpp data record format version older than 6

[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	11051
Summary	Support gtpp data record format version older than 6
Product	Wireshark
Version	1.12.4
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	Enhancement
Priority	Low
Component	Dissection engine (libwireshark)
Assignee	bugzilla-admin@wireshark.org
Reporter	tibensky233@gmail.com

Created attachment 13503 [details]
pcap with gtp data record format version 4.4.0

Build Information:
TShark 1.12.4 (ba7b1a9 from build32)

Copyright 1998-2015 Gerald Combs <gerald@wireshark.org> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GLib 2.42.1, with libpcap, with libz 1.2.3, with POSIX
capabilities (Linux), without libnl, without SMI, without c-ares, without ADNS,
without Lua, without Python, without GnuTLS, with Gcrypt 1.4.4, with MIT
Kerberos, without GeoIP.

Running on Linux 2.6.18-348.el5PAE, with locale en_US.UTF-8, with libpcap
version 0.9.4, with libz 1.2.3.

Built using gcc 4.1.2 20080704 (Red Hat 4.1.2-54).

--
Hello,
i have gprs data record packet with format version 4.4.0, i tried to modify
packet-gtp.c dissector like this:

@@ -7802,7 +7802,7 @@ decode_gtp_data_req(tvbuff_t * tvb, int offset,
packet_info * pinfo, proto_tree

             /* XXX this is for release 6, may not work for higher releases */
             if(format==1) {
-                if(rel_id == 6){
+                if(rel_id <= 6){
                     dissect_gprscdr_GPRSCallEventRecord_PDU(next_tvb, pinfo,
cdr_dr_tree, NULL);
                 }else if(rel_id >6){
                     dissect_gprscdr_GPRSRecord_PDU(next_tvb, pinfo,
cdr_dr_tree, NULL);

and it worked. Can we merge this into official wireshark or is this some kind
of bad practice?
Thak you,
Martin

---

      You are receiving this mail because:

• You are watching all bug changes.