Wireshark-bugs: [Wireshark-bugs] [Bug 10737] Wireshark should be installing icons as part of "ma
Comment # 8
on bug 10737
from Guy Harris
(In reply to Jeff Morriss from comment #4)
> The question is probably: how do we know if we're installing into a
> freekdesktop-compliant environment? Maybe freekdesktop.org will tell us.
I suspect installing in $(datadir)/wireshark/icons will work even in
non-fd.o-compliant UN*X+{X11,Wayland,Mir} environments. We can probably make
it work on OS X as well; I don't care that much about autotools-on-Windows, and
we can have CMake do the right thing on Windows, OS X, and "other", with
"other" currently meaning UN*X+{X11,Wayland,Mir}.
> I added that target when getting the icons installed for RPM-based systems.
> Another tricky point, of course, is when to do as the reminder (pasted here
> from Makefile.am) says:
>
> @echo "Don't forget to run \"update-desktop-database\" and
> \"update-mime-database /usr/share/mime\""
>
> That has to be done after the *package* is installed (if you're installing
> one) not (necessarily) at "make install" time.
Whatever post-processing needs to be done after icons are installed should be
done at "make install" time; if you're doing "make install", you're not
installing a package, you're building and installing from source.
Whatever post-processing needs to be done at *package* installation time should
be set up in the packaging mechanism or mechanisms in question.
> I guess maybe it could be
> done at "make install" time and just ignore the resulting errors when you're
> building a package (since I build my packages as myself rather than as root)?
If the process of building a package requires a "make install", then either
1) the "make install" process, when done as part of the process of building
a package, needs to be tweaked in order to allow it to be done as a non-root
user (e.g., installing under /tmp)
or
2) you don't get to make packages as yourself.
You are receiving this mail because:
- You are watching all bug changes.
