Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 10545] "BROWSER" protocol registration done in smb-browse conflicts with the "

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 8 on bug 10545 from Alexis La Goutte

(In reply to Matthieu Patou from comment #7)
> (In reply to Alexis La Goutte from comment #6)
> > Hi,
> > 
> > About regenerate dissector, why don't create a small script will be
> > regenerate all generate dissector and check there is no diff (launch a git
> > diff)
> Well it depends, if the IDL changes or if PIDL changes actually you expect
> them to change but of the time I do agree that it shouldn't change 

the major problem is, the dev don't always if the dissector is generate or
not..
and my idea is add a new easy check for regenerate all dissector and check
there is a change (Like Michael say, it is no easy on Windows to regenerate
some dissector...)

or may be move this dissector on specific folder (like generate...)

> > 
> > and it will be possible to add to check to buildbot (and petri-dish...)
> > 
> > What do you think Michael ? 
> > 
> > Matthieu, also do now forget to push all your patch on Gerrit (it is the
> > recommended step for review patch...)
> Sure will do it soon.

---

      You are receiving this mail because:

• You are watching all bug changes.