Wireshark-bugs: [Wireshark-bugs] [Bug 10545] "BROWSER" protocol registration done in smb-browse
Comment # 2
on bug 10545
from Matthieu Patou
(In reply to Michael Mann from comment #1)
> Which other dissector is causing the "name conflict"? I don't see any other
> dissectors with "BROWSER" or "browser" as a name.
See the title:
'"BROWSER" protocol registration done in smb-browse conflicts with the
"BROWSER" protocol from the pidl generated dissector'
Basically if we keep this name for the packet-smb-browse.c it prevents from
updating the packet-dcerpc-browser.c using latest version of PIDL.
>
>
> Small side note:
> There is a browser.idl in the samba source that seems like it could be
> comparible to the packet-dcerpc-browser.c (which I originally assumed was
> where the name conflict you mentioned was). Should the browser.idl go
> through the PIDL wireshark generator and replace the (manually created)
> packet-dcerpc-browser.c? The comparative side of the dissector and the idl
> made me thing the idl has either less info or is not the same.
It's just that packet-dcerpc-browser.c has not been regenerated from pidl for a
long time because we weren't able to regenerate anymore.
I almost completed an effort in Samba to have PIDL being able to generate
dissectors for any idl file that we have right now.
The branch for it is:
http://git.samba.org/?p=mat/samba.git;a=shortlog;h=refs/heads/iolab2013
So this patch is a preliminary work in order to allow the regeneration of all
the pidl based dissectors.
You are receiving this mail because:
- You are watching all bug changes.
