Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 10345] New: Recent proto.c changes break wireshark tree dissection in some cas

[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	10345
Summary	Recent proto.c changes break wireshark tree dissection in some cases
Classification	Unclassified
Product	Wireshark
Version	Git
Hardware	x86
OS	Windows 7
Status	UNCONFIRMED
Severity	Major
Priority	Low
Component	Dissection engine (libwireshark)
Assignee	bugzilla-admin@wireshark.org
Reporter	wmeier@newsguy.com

Created attachment 12954 [details]
tds capture file

Build Information:
Version 1.99.0-ws (v1.99.0-rc1-1161-g0294b29 from master)


Compiled (32-bit) with GTK+ 2.24.23, with Cairo 1.10.2, with Pango 1.34.0, with
WinPcap (4_1_3), with libz 1.2.5, with GLib 2.38.0, with SMI 0.4.8, with c-ares
1.9.1, with Lua 5.2, with GnuTLS 3.1.22, with Gcrypt 1.6.0, with MIT Kerberos,
with GeoIP, with PortAudio V19-devel (built Jul  3 2014), with AirPcap.

Running on 32-bit Windows 7 Service Pack 1, build 7601, with WinPcap version
4.1.3 (packet.dll version 4.1.0.2980), based on libpcap version 1.0 branch
1_0_rel0b (20091008), with GnuTLS 3.1.22, with Gcrypt 1.6.0, with AirPcap 4.1.1
build 1838.
Intel(R) Core(TM)2 Duo CPU     T5250  @ 1.50GHz, with 3062MB of physical
memory.


Built using Microsoft Visual C++ 10.0 build 40219

--
Some weirdness seems to have been caused by recent changes
to proto.c ((5460d7f & 3da89d6),

In one case, the protocol never appears in the 'protocol' column', isn't in the
list of protos, filters for the protocol don't work. etc etc

Oddly enough, the actual dissection for the protocol does appear in the details
pane.

See the attached tds capture file.

(I've found this problem only in a few of a small sample of capture files
examined).

--------

In other (more common ?) cases: dissections show Dissector Bug text in the Info
field.

Response[Dissector bug, protocol TDS: "Text item" - "text" tfi->tree_type:
4294967295 invalid (proto.c:3791)]

Example capture file: 465-sql-login-transaction.cap from menagerie

-------
In both cases when I reverted the two commits to proto.c, things were OK again. 



I believe the changes (5460d7f & 3da89d6) should be reverted until they are
properly tested/fixed.

---

      You are receiving this mail because:

• You are watching all bug changes.