Wireshark-bugs: [Wireshark-bugs] [Bug 10203] When merging captures, temp file has no file extens
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 18 Jun 2014 23:41:40 +0000

Comment # 1 on bug 10203 from 
(In reply to comment #0)
> Considered extending create_tempfile() (in wsutil\tempfile.c),

I.e., to give the output temporary file the appropriate extension (if there is
one) for the file type?  That makes sense.

> Is there a case for making those file types
> with weak heuristics only work by file extension?

By and large, that sounds good to me; if nothing else, it may encourage people
who want their captures readable by Wireshark to either 1) make the file format
recognizable by a magic number or strong heuristic or 2) pick an extension for
it and insist on all files in that format having their extension.

The only problem is that "weak" and "strong" are judgement calls, so there's no
algorithm to ensure that a file format is properly classified.

I'd go for giving the temporary file the right extension, if there is one, and
not worry about trying weak heuristics only if the extension matches.

You are receiving this mail because:
  • You are watching all bug changes.