Wireshark-bugs: [Wireshark-bugs] [Bug 9518] TCP PDU length shown with previous frame
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 19 Apr 2014 04:18:39 +0000

Comment # 4 on bug 9518 from 
I5470356154bec50b607e071606f49696429a0c7c makes the assumption that
tcp_dissect_pdus will be called with the tree that is passed into a protocol's
main dissection function (directly from TCP).  HTTP and HTTP2 break that
assumption.  I tried to "massage" the HTTP and HTTP2 dissectors to have them
fit into the assumption, but it just didn't work (and the bug could be lurking
in other dissectors that don't fit the assumption).

Rather than revert I5470356154bec50b607e071606f49696429a0c7c, I think a better
fix would be to have the necessary "tcp_tree" saved in packet-scoped proto
data, using p_add_proto_data().  I'll post a patch in the next day or so.

You are receiving this mail because:
  • You are watching all bug changes.