Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 9933] Questionable calling of ethernet dissector by encapsulating protocol dis

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 4 on bug 9933 from Guy Harris

(In reply to comment #3)
> Also, aren't there really 4 cases?
> 1) When you know it does not have an FCS.
> 2) When you know it does have an FCS.
> 3) When you don't know, and the ethernet dissector should check the
> pseudo-header.
> 4) When you don't know and ethernet should NOT check the pseudo-header.

Perhaps we need

   3) When you don't know, and the Ethernet dissector should check a data
structure pointed to by its "data" argument

replacing both 3) and 4).

In fact, perhaps an Ethernet pseudo-header data structure should be the data
structure in question, whether it's the one in the wtap_pkthdr structure (if
the "don't know" Ethernet dissector is called directly from the frame
dissector) or a private one filled in by the caller (if the "don't know"
Ethernet dissector is being called from some other dissector).

---

      You are receiving this mail because:

• You are watching all bug changes.