Wireshark-bugs: [Wireshark-bugs] [Bug 9903] New: Clicking reload-file ignores selected file form
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 20 Mar 2014 04:34:59 +0000
Bug ID 9903
Summary Clicking reload-file ignores selected file format reader
Classification Unclassified
Product Wireshark
Version 1.11.x (Experimental)
Hardware All
OS All
Status UNCONFIRMED
Severity Normal
Priority Low
Component Wireshark
Assignee bugzilla-admin@wireshark.org
Reporter hadrielk@yahoo.com 

Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
There's a relatively new feature in 1.11.3 to select a specific file format
reader, instead of relying on magics or heuristics. If you select a file reader
and open a file, open it, and then click the reload-file button or go to
View->Reload or press the ctrl-R keymap, the file is reloaded but using the
magic/heuristics again instead of the file format reader you previously chose.

This happens because the noted methods above call cf_reload(), given only the
capture_file struct, and inside cf_reload() it simply uses the reader type of
WTAP_TYPE_AUTO again to cf_open() the file.

I've done a search and it appears cf_reload() is only used by the noted methods
above, as well as the Lua reload() function (which is how I discovered this
problem). I think the right thing to do would be either to change cf_reload()
signature/prototype to have a second argument for the type number, or perhaps
put the info in the capture_file struct itself and have it get it from there.
Probably the latter is a better move, since we also have to store the file's
current reader type somewhere, which is nowhere right now afaict.

You are receiving this mail because:
  • You are watching all bug changes.