Wireshark-bugs: [Wireshark-bugs] [Bug 3232] dissectors for totemnet and totemsrp protocols imple
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 18 Mar 2014 17:25:58 +0000

Comment # 27 on bug 3232 from 
(In reply to comment #26)
> Updated dissector review can be found at:
> https://code.wireshark.org/review/#/c/725/
> 
> Presuming the licensing stuff is okay, my big comment would be I'm not sure
> we want LibTomCrypt copy/pasted into these dissectors.   It should probably
> be separated out into epan/crypt directory (with full/complete LibTomCrypt
> files)

Thank you for reviewing. I'm new to the review tool. Is there detailed comments
in the pages of https://code.wireshark.org/review/#/c/725/?
(I cannot find such page or a link for the page.)

If not, I'll work on splitting LibTomCrypt file from the dissectors.

You are receiving this mail because:
  • You are the assignee for the bug.
  • You are watching all bug changes.