Wireshark-bugs: [Wireshark-bugs] [Bug 5575] Patch to fix memory leaks/errors in Lua plugin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 21 Feb 2014 07:31:53 +0000

Comment # 29 on bug 5575 from 
Some random comments for patch 4/6 "Refactor expiring of packet frame
values. (use ep_alloc instead of g_malloc)":

Wow, that's a lot of (unrelated) code changes. :)

I don't grok it all yet, but some thing stand out: the removal of
extraneous non-null pointer checking and such has already been done
(just this week in fact, because it annoyed me too).

The changes to attribute getters/setters no longer applies, as that's
all been refactored.

I don't yet grok the changes to replace the clear_outstanding stuff
with Lua management instead, and while I also find the current
clear_outstanding thing to be super-ugly, I don't have any test suites
written for verifying that stuff continues to work if it's changed.
(ie, I wouldn't make whole-sale changes to that unless it could be
proven to work by using a testscript :)

For the replacement of g_malloc with ep_alloc (or wmem), yeah I get
where you're going with it, but is it really a problem worth fixing?

For the change in handling columns, yeah I too find the current code
ugly for that, and it's on my list to refactor eventually.

You are receiving this mail because:
  • You are the assignee for the bug.
  • You are watching all bug changes.