Wireshark-bugs: [Wireshark-bugs] [Bug 9690] DHCPv6 Packet dissector incorrectly handling FQDN in
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 19 Feb 2014 21:15:19 +0000

changed bug 9690

What Removed Added
Status IN_PROGRESS RESOLVED
Resolution --- FIXED

Comment # 11 on bug 9690 from 
(In reply to comment #10)
> (In reply to comment #9)
> > Why not use the same mechanism as IPv4?
> > add: 
> >   const guchar	*dns_name;
> > 
> > replace all under case PKT_CCCV6_KRB_REALM:
> >   if (subopt_len > 0) {
> >     get_dns_name(tvb, suboptoff, subopt_len, suboptoff, &dns_name);
> >     proto_item_append_text(vti, " %s (%u byte%s)", dns_name, subopt_len - 1,
> > plurality(subopt_len, "", "s") );
> >   }
> 
> Ok...

Actually:

I chose not to use get_dns_name() but to use dhcpv6_domain() in packet-dhcpv6.c

The main reason: get_dns_name() allows the "compression" format which is not
valid for this field. I also changed an existing use of get_dns_name() in
packet-dhcpv6.c for the same reason.

See:
  https://code.wireshark.org/review/#/c/256/ ;; remove code for non-existing
                                             ;;  options
  https://code.wireshark.org/review/#/c/257/ ;; work related to FQDN fields


I expect that a variant of get_dns_name() will be created before too long which
is a bit more general (and maybe which will allow specification of the formats
to be allowed).

I imagine it maybe should handle the punycode format as well.

Once this work has been done, then packet-dhcpv6.c can be reworked a bit more.

You are receiving this mail because:
  • You are watching all bug changes.