Wireshark-bugs: [Wireshark-bugs] [Bug 9424] Implement ZigBee Green Power dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 18 Dec 2013 08:34:50 +0000

Comment # 15 on bug 9424 from 
Hello!

> Not sure g_malloc should be used here anyway.

However, g_malloc is used in packet-zbee-security dissector in the same case.

> The use of pinfo->private_data is trying to be deprecated
> dec_buffer can leak if dissector is called (return before free)
> Many cases of 0x%01x should be 0x%02x (digits, not bytes)
> Most notiby structures being populated with few fields really being necesary
> still some lindering proto_tree_add_text values

Fixed.

The rest of the issues were fixed too. DSR provided the new Green Power patch
based on the obsolete DSR patch, the changes made by your cleanup in attachment
12262 [details] and the new ZigBee Green Power spec. The new patch is created for
revision 54208. Please check it. Let's keep in touch.

You are receiving this mail because:
  • You are watching all bug changes.