Wireshark-bugs: [Wireshark-bugs] [Bug 9560] New: Remove misleading dereference operator in the R
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 15 Dec 2013 17:02:39 +0000
Bug ID 9560
Summary Remove misleading dereference operator in the RTPproxy dissector
Classification Unclassified
Product Wireshark
Version unspecified
Hardware All
OS All
Status UNCONFIRMED
Severity Enhancement
Priority Low
Component Wireshark
Assignee bugzilla-admin@wireshark.org
Reporter lemenkov@gmail.com 

Created attachment 12304 [details]
Initial patch

Build Information:
wireshark 1.11.3 (SVN Rev Unknown from unknown)

Copyright 1998-2013 Gerald Combs <gerald@wireshark.org> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.24.22, with Cairo 1.13.1, with Pango 1.36.1, with
GLib 2.38.2, with libpcap, with libz 1.2.8, with POSIX capabilities (Linux),
without libnl, with SMI 0.4.8, with c-ares 1.10.0, with Lua 5.2, without
Python,
with GnuTLS 3.1.17, with Gcrypt 1.5.3, with MIT Kerberos, with GeoIP, with
PortAudio V19-devel (built Aug  4 2013 06:59:20), with AirPcap.

Running on Linux 3.11.10-300.fc20.x86_64, with locale ru_RU.UTF-8, with libpcap
version 1.5.0, with libz 1.2.8, GnuTLS 3.1.17, Gcrypt 1.5.3, without AirPcap.
       Intel(R) Core(TM) i5-2415M CPU @ 2.30GHz

Built using gcc 4.8.2 20131017 (Red Hat 4.8.2-1).
--
Hello All.

This patch removes misleading dereferencing operator from the array's name.
E.g. consider the following declaration:

guint32 ipaddr[4];

ipaddr points to the address of an array of guint32's, while &ipaddr points to
the first' guint32 object. E.g. &ipaddr == &ipaddr[0]. The value is the same,
but has different type which is necessary sometimes. However inet_pton treats
latest argument as void*, and this information is left anyway. So no need to
bother with types and let's just pass pointer to the array.

You are receiving this mail because:
  • You are watching all bug changes.