Wireshark-bugs: [Wireshark-bugs] [Bug 7893] Bluetooth: Add support for AVDTP/A2DP/VDP and SBC co
Date Prev · Date Next · Thread Prev · Thread Next
Date: Sat, 30 Nov 2013 22:52:58 +0000

Comment # 81 on bug 7893 from
(In reply to comment #77)
> Reason for move codecs.[ch] is: (hmm.. I do not remember, it was one year
> ago :)) As I remember it is for clean ui/gtk/rtp_player.c, provide more
> consistent ui/gtk/main.c and codecs library (not needed to expose additional
> header of any functions/methods of codecs: currently 5 per codec).

The only reason I can see to have any of the codec stuff in libwireshark is
that the plugin mechanism is currently in libwireshark.

That might have made sense when the only plugins we supported were dissector
plugins, and maybe was sort of OK when we also had tap plugins that depended on
dissectors, but now that we have libwiretap plugins to read file formats, and
have programs that use libwiretap but not libwireshark, it no longer makes
sense.  There's currently a sleazy build hack that makes it work.

We should move the plugin mechanism to libwsutil, remove all its knowledge of
particular types of plugins, and add APIs to allow users of the plugin
mechanism to specify the characteristics of their own plugin types (e.g., the
names of register routines).  Then we could have a libaudiocodec (or whatever)
that handles audio codecs, using that mechanism, with which Wireshark (but not
TShark) would be linked.


You are receiving this mail because:
  • You are watching all bug changes.