Wireshark-bugs: [Wireshark-bugs] [Bug 5206] Wireshark incorrectly processes SMPP optional parame
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 30 Nov 2013 19:06:46 +0000

Comment # 9 on bug 5206 from 
(In reply to comment #8)

Thanks for the feedback, Petr. 

> My opinion is that while it is very good to have such an option, the primary
> method of determining the length of the C-Octet string value in any TLV
> parameter should be the Length field of the TLV.
I think it would be good to have it configurable anyway and have the preference
set to using the length (from the TLV) as default.

> For these reasons I would prefer to change the text of the warning message
> 
> Actual (14) & claimed length (13) don't match. Decoding of rest of the PDU
> might fail on SMSC/ESME!
> to
> C-Octet string is not null-terminated!
> or
> Null terminator not found at the end of C-Octet string!
I agree. Actually a similar message was already in the patch and appears in the
status bar if the expert information is selected. 

I will submit a proper patch for review as soon as possible.

You are receiving this mail because:
  • You are the assignee for the bug.
  • You are watching all bug changes.