Wireshark-bugs: [Wireshark-bugs] [Bug 9452] Patch: Stats_tree enhancements for sorting, averages
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 30 Nov 2013 06:25:48 +0000

Comment # 3 on bug 9452 from 
(In reply to comment #2)

> All looks good, but since we've switched to using Qt, functionality needs to
> be included there as well.  Most of the patch isn't GTK+ specific, so no
> need to reject on those grounds.  Keeping open for the Qt effort. Should
> also be be able to remove now deprecated stats APIs
> (stats_tree_get_strs_from_node) when that happens.

I've started working on the Qt ui. Couple of questions:

1) Do you want to retain "Copy as YAML" as a separate button? I'm inclined to
add YAML as format for "Save as" and just have a "Copy" (as plain text) and
"Save as" buttons.

2) The GTK+ ui recalculates the stats_tree when (relevant) preferences are
changed while the Qt ui version destroys the stats_tree after drawing it the
first time (no recalculations). Which is the preferred behaviour? I'm leaning
towards replicating the GTK+ behaviour.

You are receiving this mail because:
  • You are watching all bug changes.