Wireshark-bugs: [Wireshark-bugs] [Bug 9424] Implement ZigBee Green Power dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 29 Nov 2013 15:58:44 +0000

changed bug 9424

What Removed Added
Attachment #12145 Flags review_for_checkin? review_for_checkin-

Comment # 10 on bug 9424 from 
Comment on attachment 12145 [details]
patch for ZigBee Green Power (fixed)

A few comments:

1. Patch no longer applies cleanly, probably due to patches committed from bug
9423.

2. "Prefix" of all display filters should match display filter.  Not sure if
ZBEE_PROTOABBREV_NWK_GP should be adjusted or all of the display filters. 
There are a lot of zbee dissectors, so I'm not sure of the correct prefix
format here, but they should be consistent.

3. Are there any logic changes to dissect_zbee_nwk_heur()?  The previous code
looked a lot cleaner IMO, why add a do-while loop that doesn't ever loop?

4. Are any of the #defines in packet-zbee-nwk-gp.h used outside of
packet-zbee-nwk-gp.c?  If not, they should just be included in
packet-zbee-nwk-gp.c to avoid "file polution".

5. I think the (most if not all) functions in packet-zbee-nwk-gp.c can be
reordered to avoid the static declarations at the top of the file.  Makes it
easier to change function parameters in the future (and not update them twice).

You are receiving this mail because:
  • You are watching all bug changes.