Wireshark-bugs: [Wireshark-bugs] [Bug 9397] Add RTP/RTCP dissector setup based on the replies fo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 26 Nov 2013 10:01:31 +0000

Comment # 3 on bug 9397 from 
(In reply to comment #2)

> when looking at the code of rtp_add_address/rtcp_add_address (that call
> conversation_new) it lookshttps://bugs.wireshark.org/bugzilla/attachment.cgi?bugid=9397&action="" like you do not need to copy the address in file
> scoped memory. A packet scoped memory or a local variable will be sufficient
> as conversation_new calls SE_COPY_ADDRESS. Could you give it a try and
> confirms it works fine?

Fixed (switched to wmem_packet_scope() and it works fine):

https://github.com/lemenkov/wireshark/commit/0e13325

> Moreover your patch does not compile on Windows. You lack the following
> include:
> #ifdef HAVE_WINSOCK2_H
> #include <winsock2.h>       /* needed to define AF_ values on Windows */
> #endif

Added, thanks for pointing on this:

https://github.com/lemenkov/wireshark/commit/cc27ba8

A new combined patch will be attached shortly.

You are receiving this mail because:
  • You are watching all bug changes.