Wireshark-bugs: [Wireshark-bugs] [Bug 9469] Patch: set dissector for a specific source+dest port
Comment # 5
on bug 9469
from Deon van der Westhuysen
Thanks Guy, Michael
Lesson learned re: SVN! LOL. I like the idea of a dissector being able to tell
decode-as what it considers to be a conversation.
Thinking about it some more - wouldn't it make sense for the dissector to pass
an opaque structure to decode-as? Then the dissector is in complete control of
how a conversation is defined? (The dissector would have to expose functions to
format the structure for display and loading/saving prefs; there could be
predefined functions for standard structures). This would be nice and generic,
hopefully without killing performance. Dissectors could choose to supply a
struct for complex scenarios or just simple integer values using
GUINT_TO_POINTER macros (this provides a nice migration path from the current
integer only environment).
This wouldn't be such a major change? It would call for a new pointer-type
dissector table in packet.h/packet.c and new try_dissector functions as well as
new UI support code.
How does that sound?
With regards the current patch - it doesn't seem too difficult to adapt it to
the current SVN trunk. Do you think, given above discussions, there is still
value in pursuing this patch? It has the weakness that is only considers port
numbers, and not hosts too, in determining conversations.
You are receiving this mail because:
- You are watching all bug changes.
