Wireshark-bugs: [Wireshark-bugs] [Bug 9470] Packet scoped "proto" data
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 22 Nov 2013 22:07:57 +0000

Comment # 4 on bug 9470 from 
(In reply to comment #3)
> Leaving the sorted GSList aside, what about just copy-pasting the majority
> of the p_*_proto_data code to build a set of pinfo_*_proto_data functions?
> The code duplication feels less bad than switching on the pool somehow.
> Urgh, my brain is not up to this right now, sorry.

I wanted to make it like the tvb_ functions you recently converted, but the
issue is I need allocator + GSList.  I think having dissectors know their scope
should be enough, I don't want them to have to pick a GSList since there is a
1-1 mapping currently between allocator and GSList.  I also thought "hiding"
the GSList made some of the other memory permutations mentioned on -dev easier
to implement (ie not needing another copy of <another_scope>_proto_data)

You are receiving this mail because:
  • You are watching all bug changes.