Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 9453] New: use 32bit key in p_add_proto_data() and friends

[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	9453
Summary	use 32bit key in p_add_proto_data() and friends
Classification	Unclassified
Product	Wireshark
Version	SVN
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	Enhancement
Priority	Low
Component	Common utilities (libwsutil)
Assignee	bugzilla-admin@wireshark.org
Reporter	doj@cubic.org

Created attachment 12123 [details]
use 32bit key in p_add_proto_data() and friends

Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
for my current development, I'd like to use more than 8 bits for the key in
p_add_proto_data() and related functions. Simply changing the key size to 32bit
is straight forward and shouldn't even increase the size of the allocations
(considering a min 32bit alignment of variables in structures). See the
attached patch for details.

Code which is using p_add_proto_data() with 8bit key values should not be
changed, unless they are buggy and relied on the removal of the upper 24 bits
of the current code. A grep through the code shows that the majority of
function calls use 0 as the key value, so all these are safe.

---

      You are receiving this mail because:

• You are watching all bug changes.