Wireshark-bugs: [Wireshark-bugs] [Bug 8070] Patch for packet-coap.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 14 Nov 2013 16:07:33 +0000

changed bug 8070

What Removed Added
Status RESOLVED INCOMPLETE
CC   wmeier@newsguy.com
Resolution FIXED ---

Comment # 18 on bug 8070 from 
Shoichi:

While looking at packet-coap.c I noticed what seems to me to be a minor bug in
dissect_coap_opt_uri_query().

Specifically: it seems to me that the g_strlcat marked below should be
concatenating to 'coap_uri_query' and not to 'coap_uri_str'.

If you can confirm, I'll make the change.

Thanks

-------

dissect_coap_opt_uri_query(tvbuff_t *tvb, proto_item *head_item,proto_tree
*subtree, gint offset, gint opt_length)
{
    const guint8 *str = NULL;

    [...]

    if (opt_length == 0) {
        str = nullstr;
    } else {
        str = [...];
==>        g_strlcat(coap_uri_str, str, sizeof(coap_uri_str));
    }
    [...]

}

You are receiving this mail because:
  • You are watching all bug changes.