Wireshark-bugs: [Wireshark-bugs] [Bug 8594] Adding support for IEEE-802.11ad protocol at the cur
Comment # 24
on bug 8594
from Guy Harris
(In reply to comment #23)
> (In reply to comment #22)
> > Corrected some whitespace issues as well as a typo found by checkAPIs.pl.
> > Overall the patch looks pretty good, but is there an easier way to do the
> > IS_80211AD macro? Perhaps use p_add_proto_data/p_get_proto_data?
>
> Probably. The search for "Channel frequency" will match a couple of
> different fields, I'm not sure if that's intended or not:
> - ppi.80211-common.chan.freq
> - radiotap.channel.freq
> - radiotap.xchannel.freq
> - wlan.channel_frequency
The intent is presumably to distinguish 60 GHz packets from other packets.
There's no guarantee that an 802.11 packet will have radio metadata, and, even
if it does, there are several different types of radio metadata that could be
present.
The only things the dissector appears to do differently for 60 GHz packets
("directional multigigabit", or "DMG") and other packets are:
adding expert info warnings about some types of packets that shouldn't be
sent by 60 GHz STAs;
labeling the sender MAC address of a CTRL_CFP_END control frame;
dissecting the TAG_TSPEC tag differently.
Perhaps the dissectors for radio metadata should pass to the 802.11 dissector
some data that indicates, among other things, whether the frame is a 60 GHz
frame. If no such information is passed, the 802.11 dissector should assume
the frame isn't a 60 GHz frame.
You are receiving this mail because:
- You are watching all bug changes.
