Wireshark-bugs: [Wireshark-bugs] [Bug 9420] New: logically dead code in packet-rfid-pn532.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 12 Nov 2013 09:33:33 +0000
Bug ID 9420
Summary logically dead code in packet-rfid-pn532.c
Classification Unclassified
Product Wireshark
Version unspecified
Hardware x86
OS All
Status UNCONFIRMED
Severity Major
Priority Low
Component Dissection engine (libwireshark)
Assignee bugzilla-admin@wireshark.org
Reporter wireshark@kaiser.cx 

Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
coverity reported a defect about this

command_data_t  *command_data = NULL;

if (cmd>0 && ...)
   command_data = ...

    switch (cmd) {                                                              
    case DIAGNOSE_REQ:      (this is defined to 0)                              

        if (command_data)                                                       
this code will never be executed
            command_data->data.test_number = test_number;                       


I'm not familiar with the protocol so I'm not sure how to fix this

Would it make sense to check if (cmd>=0 && ...)?

You are receiving this mail because:
  • You are watching all bug changes.