Wireshark-bugs: [Wireshark-bugs] [Bug 9418] New dissector: Kyoto Tycoon binary protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 11 Nov 2013 16:59:54 +0000

changed bug 9418

What Removed Added
CC   wireshark@kaiser.cx

Comment # 4 on bug 9418 from 
Hi,

some quick comments

- please add editor modelines
http://www.wireshark.org/tools/modelines.html

- please don't increment *offset under if (tree)

I would assume that the position of the elements does not change depending on
tree. Almost all parsing functions can deal with tree==NULL, so it should be
safe to remove the if(tree).

- I personally don't like the *offset param. You could make the functions
return the new offset. But as I said, that's my personal preference...

- I keep forgetting about our rules for port numbers not officially assiged by
IANA. Port 1978 and 1979 are mentioned explicitly in the spec. You should at
least create a protocol preference for the two ports so that users can change
them.

Regards,
Martin

You are receiving this mail because:
  • You are watching all bug changes.