Wireshark-bugs: [Wireshark-bugs] [Bug 9387] New: Remove pinfo->private_data from DCERPC dissecto
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 05 Nov 2013 17:18:29 +0000
Bug ID 9387
Summary Remove pinfo->private_data from DCERPC dissectors
Classification Unclassified
Product Wireshark
Version SVN
Hardware All
OS All
Status CONFIRMED
Severity Enhancement
Priority Low
Component Dissection engine (libwireshark)
Assignee bugzilla-admin@wireshark.org
Reporter mmann78@netscape.net
Attachment #12016 Flags review_for_checkin? 

Created attachment 12016 [details]
Complete DCERPC removal of pinfo->private_data

Build Information:
SVN r53087
--
I took the plunge and removed the dcerpc_info* infomation from
pinfo->private_data and instead have the dissectors pass it in as an argument.

While the change itself is MASSIVE, it was fairly easy to do.  I just made a
few small changes in dcerpc.h and .c and let the compiler do the rest (in
telling me how many more places needed a dcerpc_info* argument).  Several
iterations later (with the power of search/replace), I got something that built
with all of the necessary dcerpc_info*.

How should I proceed?  The biggest problem with this patch is that I haven't
modified the "source" for the generated PIDL dissectors.  I just did all of the
edits manually, and figured "syncing the source" could be done after the fact. 
Should I wait until that sync is done before committing it all?  While the
generated source is a very high percentage of the patch size, it's probably
only 20% of the functionality change.

My current thought it to check the whole thing in, but not close the bug until
the generated "input source" has been synced and sent upstream to samba.

You are receiving this mail because:
  • You are watching all bug changes.