Wireshark-bugs: [Wireshark-bugs] [Bug 9323] Buildbot crash output: fuzz-2013-10-25-12569.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 30 Oct 2013 02:15:25 +0000

Comment # 32 on bug 9323 from 
Tried another fix in r52979. This one should be safer/saner/more acceptable.

In short:
- proto_tree_add_string_* do require the string passed in to be
null-terminated, because its contents have no relation to the length passed in
(if it is generated, for example)
- in this case it was the formatting that seemed necessary, as the string came
directly from a tvb_get_ptr, so I just converted to a proto_tree_add_item and a
proto_tree_set_text

As far as I can tell nothing here actually needs backporting, so if there are
no problems with the current patch this can be closed.

You are receiving this mail because:
  • You are watching all bug changes.