Wireshark-bugs: [Wireshark-bugs] [Bug 8275] Basic dissector: FIPA/ACL Message protocol over TCP
Raúl Pérez Clavero
changed
bug 8275
| What |
Removed |
Added |
| Attachment #11093 is obsolete |
|
1
|
Comment # 20
on bug 8275
from Raúl Pérez Clavero
Created attachment 11919 [details]
Patch File with new expert API and other fixes
In reply to comment #18)
>
> When capturing packets, there is an option to only capture the first so many
> bytes of each packet (if, for example, you're only interested in the TCP
> headers and not the payloads, this can make capture much faster). In this
> case, tvb_reported_length() will be the real size that was sent on the wire
> while tvb_length() will be only what was captured. It's usually better to
> use tvb_reported_length() because that way the packet *looks* like the right
> length to the dissector, and if it runs past what was actually captured
> Wireshark automatically stops and just says 'packet truncated at capture
> time'.
- tvb_length() calls replaced with tvb_reported_length()
> - There is a function tvb_find_guint8() that I think you can use instead of
> manually looping through the tvb looking for specific values (for example in
> acl_get_bounds).
- tvb_find_guint8() function used instead of manually looping through tvb
>
> - There is now a new expert information API where you can register your
> expert info items similar to how you register your hf items. Look for ei_ in
> packet-bthfp.c for a good example how to use it.
- New expert information API used.
>
> - Please include your dissector in epan/CMakeLists.txt as well as
> epan/dissectors/Makefile.common
>
- DONE
> - ./tools/checkhf.pl complains: Unused entry: epan/dissectors/packet-acl.c,
> hf_acl_body
- FIXED
> - ./tools/checkAPIs.pl complains: Error: Found C++ style comments in
> epan/dissectors/packet-acl.c
- FIXED
> - Are all of the default ports registered with the IANA? If not, it may be
> better to not register on them by default to avoid conflicts with officially
> registered ports.
- No default ports are defined.
You are receiving this mail because:
- You are watching all bug changes.
