Wireshark-bugs: [Wireshark-bugs] [Bug 9328] Suppress VS2013 Warnings
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 26 Oct 2013 13:12:43 +0000

changed bug 9328

What Removed Added
Status UNCONFIRMED INCOMPLETE
Ever confirmed   1

Comment # 2 on bug 9328 from 
+/*
+Starting VS2103, rint already defined in math.h. no need to redefine
+rlc_lte_graph.c(347): error C2371: 'rint' : redefinition; different basic
types
+Microsoft Visual Studio 12.0\VC\include\math.h(515) : see declaration of
'rint'
+*/
+#if (_MSC_VER < 1800)
 #if defined(_WIN32) && !defined(__MINGW32__)
 static int rint(double );     /* compiler template for Windows */
 #endif
+#endif

1. I expect this won't build on a non-Windows system since _MSC_VER won't be
defined.

    The '#if (_MSCVER < 1800)'  needs to be inside the '#if defined(_WIN32)...'

2. There's no need to include the compiler error message in the comment: using
just the first line is OK.

You are receiving this mail because:
  • You are watching all bug changes.