Wireshark-bugs: [Wireshark-bugs] [Bug 8974] Patch to support krb FAST PA Data types
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 24 Oct 2013 12:54:45 +0000

Comment # 8 on bug 8974 from 
Hi Jakob, I'm not familiar enough with the protocol to comment on everything
but I can provide some pointers.

- for memory issues, you can use the wmem framework (take a look at
doc/README.wmem and possibly doc/README.malloc for context)

- please don't use globals at all except for the "standard" uses of hf_ and
ett_ variables

- ./tools/checkAPI.pl complains:
Error: the blurb for hf_krb_fast_armored_rep ("kerberos.fast.armored.rep") has
trailing space in epan/dissectors/packet-kerberos.c

Thanks,
Evan

You are receiving this mail because:
  • You are watching all bug changes.