Wireshark-bugs: [Wireshark-bugs] [Bug 9297] Support for VS2013 on Windows
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 20 Oct 2013 16:00:05 +0000

Comment # 6 on bug 9297 from 
(In reply to comment #5)
> (In reply to comment #3)
> I've tested the patch on VS2013. it compile without error and runs also as
> expected.

Thanks for testing.

> We can also use the WinHelper function
> 
> IsWindows*

Assuming you are referring to versionhelpers.h, it as some drawbacks:
- requires to install Windows 8.1 SDK
- allows just to identify than an OS is equal or greater than a given version
So multiple calls to VerifyVersionInfo() is still required.

> 
> or we can baypass the warnig for deprecated function by adding
> 
> !IF "$(MSVC_VARIANT)" == "MSVC2013"   || \
>         "$(MSVC_VARIANT)" == "MSVC2013EE"
> LOCAL_CFLAGS=$(LOCAL_CFLAGS) /DBUILD_WINDOWS
> !ENDIF
> 
> in the config.nmake file
> 
> and continue use the GetVersionEx (without changes in the source)

Good to know. We would still need the manifest modification given in comment #4
to identify Windows 8.1 though.

You are receiving this mail because:
  • You are watching all bug changes.