İbrahim Can Yüce
changed
bug 9217
| What |
Removed |
Added |
| Attachment #11782 Flags |
|
review_for_checkin?
|
Comment # 15
on bug 9217
from İbrahim Can Yüce
Created attachment 11782 [details]
new s5066dts dissector code patch
after taking the previous comments into consideration, I implemented the
following changes and uploaded the new dissector patch named as
s5066dts_dissector_code_patch_new as an attachment:
- removed unnecessary forward references and macro defs.
- modified the dissector function calls, "register_dissector" and
"create_dissector_handle", into the new ones and added the return expressions
as well.
- removed library inclusions that are commented out.
- converted some of the "proto_tree_add_text" calls to expert info API calls.
- removed all unnecessary "col_clear" function calls.
- created CRC look-up tables calculated for the specified polys(16bit header
and 32bit payload) in STANAG 5066 and put it into amidst other tables under the
related wsutil/crc* file with the checksum computation routine in there.
- defined separate dissectors for the "encapsulated in TCP" vs. "directly
captured from the line" and removed the regarding configuration from the
preferences menu.
thanks all.
You are receiving this mail because:
- You are watching all bug changes.
