Wireshark-bugs: [Wireshark-bugs] [Bug 9261] openSAFETY: Dissection for second crc as well as pla
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 10 Oct 2013 18:16:28 +0000

Comment # 2 on bug 9261 from 
(In reply to comment #1)
> Second, the first CRC has opensafety.crc.data and opensafety.crc.type fields
> as well as opensafety.crc.valid field.  Should those other fields exist for
> the second crc as well?

That is ok. Data will never be searched, as it is not interesting. Type will
allways be the same for both CRCs in a single package, and crc2 has a second
valid field. (opensafety.crc2.valid). The important information here is
actually if the second one is valid, and the bytes selected when the info is
added to the tree.

> Third, it would be most useful to attach a sample trace to this bug report
> so that your enhancements can be more easily seen and tested. 

This patch can be tested by using any of the other opensafety traces already in
the system. But most importantly, it can easily be tested using the sample
traces from: http://wiki.wireshark.org/SampleCaptures#openSAFETY

You are receiving this mail because:
  • You are watching all bug changes.