Wireshark-bugs: [Wireshark-bugs] [Bug 9232] Buildbot crash output: fuzz-2013-10-04-22971.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 07 Oct 2013 13:20:36 +0000

Comment # 7 on bug 9232 from 
(In reply to comment #6)
> Created attachment 11722 [details]
> [PATCH 1] Bluetooth: SDP: Do real length check of info string
> 
> Idea with wmem_strbuf works fine - valgrind is clean. Patch attached.

Looks good, two minor questions:
- It was previously wmem_packet_scope() but is now wmem_file_scope()?
- It was previously 1024 chars and is now only 240 chars?

There are also a few places you use _append_printf without any format commands
(so just _append will do) but that doesn't affect behaviour at all, it's just
optimization.

You are receiving this mail because:
  • You are watching all bug changes.