Wireshark-bugs: [Wireshark-bugs] [Bug 9217] STANAG 5066 DTS Layer dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 02 Oct 2013 19:19:17 +0000

changed bug 9217

What Removed Added
Attachment #11694 Flags review_for_checkin? review_for_checkin-

Comment # 5 on bug 9217 from 
Comment on attachment 11694 [details]
dissector code patch

Some additions to Alexis' comments:

1. Do all of the functions really need forward references?  Can't the code be
constructed so that function definitions are before their use?
2. Looks like this dissector should be a "new" style dissector and return 0 if
the packet doesn't look like it's a STANAG 5066 one.
3. Remove #include <stdio.h> since it's defined out anyway.
4. Some of the proto_tree_add_text calls can be converted to expert info API
(ex. in dissect_s5066dts_eow_hftrp())
5. I don't believe columns need to be explicitly cleared before they are set.
6. Please put crc routines into epan/crc*-tvb.h

You are receiving this mail because:
  • You are watching all bug changes.