Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 9072] Enhancement of the packet-mq dissector (WMQ 7.1-7.5)

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 41 on bug 9072 from Evan Huus

A few warnings left similar to the following:

packet-mq.c: In function 'dissect_mq_pmr':
packet-mq.c:1422:66: error: declaration of 'mq_int_rep' shadows a global
declaration [-Werror=shadow]
 static gint dissect_mq_pmr(tvbuff_t *tvb, proto_tree *tree, gint mq_int_rep,
gint offset, gint iNbrRecords, gint offsetPMR, guint32 recFlags)

Though I notice that the variable being shadowed is a global - please do not
use globals except where necessary (hf_ and ett_, preferences, dissector
handles).



And a few other warnings, having been uncovered by previous fixes I guess:
packet-mq.c: In function 'reassemble_mq':
packet-mq.c:3272:4: error: comparison is always false due to limited range of
data type [-Werror=type-limits]
    if ((iOpcd > 0x80 && !(bSeg1st && bSegLst)) || iOpcd==MQ_TST_ASYNC_MESSAGE)
packet-mq.c: In function 'dissect_mq_charv.constprop.15':
packet-mq.c:1411:5: error: 'sStr' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
  ti = proto_tree_add_text(tree, tvb, offset, iSize, "%s -
%s",pStr,(lStr)?sStr:sEmpty);

---

      You are receiving this mail because:

• You are watching all bug changes.