Wireshark-bugs: [Wireshark-bugs] [Bug 9143] Update spice protocol dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 13 Sep 2013 13:38:22 +0000

Comment # 2 on bug 9143 from 
Hi Michael, 

the message at the top of the patch explains a bit of the reason for the
separate header file / renaming.  Essentially, the header file I've included is
generated automatically from a protocol definition.  The code generator uses
slightly different (and more consistent) naming style than the old
manually-maintained #defines / enums.  Thus the renaming.  

I thought that maintenance would be easier if all of the generated code was in
a separate header file.  If you don't like the separate header, I can combine
them into the .c though I guess.

I just realized that I didn't add the new header to the build system at all
though, so if we kept that as a separate file, this patch might still need more
work.

For the sample capture -- is there a size limit for this?  Anything special I
should do?

You are receiving this mail because:
  • You are watching all bug changes.