Wireshark-bugs: [Wireshark-bugs] [Bug 9047] EPL: Dissection for WriteMultipleParameter, Node Ali
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 09 Sep 2013 16:56:44 +0000

changed bug 9047

What Removed Added
Attachment #11514 is obsolete   1
Attachment #11514 Flags review_for_checkin?  
Attachment #11530 Flags   review_for_checkin?

Comment # 11 on bug 9047 from 
Created attachment 11530 [details]
EPL: Dissection for WriteMultipleParameter, Node Alias, SDO/ASND structuring,
AInv Message

Hi

For the whitespace changes, I may have taken Michaels comment a little bit to
serious and went overboard with them. I did use BeyondCompare to review the
changes, and they look good to me.

As for your comments, I changed the payload behaviour to a bytes field (I do
not like the encoding at all, as I prefer uppercase Hex values, but it is fine
for me). Also, I did take another look at the epl_tree changes, and I would
combine the change now. In the future I would commit something like that
separately (again took Michaels suggestion a little too far).

"val_to_str_const(svid, asnd_svid_vals, "Unknown"), svid)" -> I have not
changed, as it should mirror the behaviour of the EPL dissector for OmniPeek
(also developed by B&R) and by using the hf_fields I could not reproduce the
same information.

guint is respected now, and unnecessary instances have been removed (I am a
rather defensive programmer)

As usual the patch has been fuzz tested

You are receiving this mail because:
  • You are watching all bug changes.