Wireshark-bugs: [Wireshark-bugs] [Bug 9120] Buildbot crash output: fuzz-2013-09-08-32595.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 09 Sep 2013 02:29:16 +0000

changed bug 9120

What Removed Added
CC   eapache@gmail.com

Comment # 1 on bug 9120 from 
Apparently the private_data pointer is still pointing to a TCP struct when it
reaches code that expects it to be an SMB struct, and this happens. Not sure at
which point in the stack trace we're supposed to be able to find an SMB struct
to assign.

It appears that it's *only* used for determining whether or not to extract
strings using Unicode (presumably yes, for smb2) so it may be enough to just
point it to a temporary struct on the stack with that member initialized, and
then restore the old version after.

This seems in general like an error-prone way of storing and communicating
data, especially when a dissector could be called from several different
higher-layer protocols and thus can't know what to cast private_data to. Does
anyone know if this has been deprecated in favour of some better method?
p_get_proto_data() doesn't seem appropriate because it's persistent...

You are receiving this mail because:
  • You are watching all bug changes.