Wireshark-bugs: [Wireshark-bugs] [Bug 9105] Additional PN532 opcodes, and update USB CCID dissec
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 06 Sep 2013 21:36:17 +0000

changed bug 9105

What Removed Added
Status UNCONFIRMED IN_PROGRESS
CC   pascal.quantin@gmail.com
Ever confirmed   1

Comment # 4 on bug 9105 from 
(In reply to comment #2)
> Created attachment 11512 [details]
> An updated version that also dissects ATS length bytes, for visual sanity
> checking
> 
> Panic averted, after taking a deeper look at the same trace file...
> 
> Anyway, just to be certain, and to fill in a mysterious gap in dissection, I
> ended up implementing support for dissecting the ATS length byte, too.

Hi Tyson,

looks good to me. Just a small thing: as you now remove the SW1SW2 code
directly in packet-usb-ccid.c, all the (length-2) spread all over the
packet-rfid-pn532.c file seems a bit mysterious unless you check
packet-usb-ccid.c. Why not simply put the new constant value (without the -2)?

Regards,
Pascal.

You are receiving this mail because:
  • You are watching all bug changes.