Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 9072] Enhancement of the packet-mq dissector (WMQ 7.1-7.5)

[bugzilla-daemon@xxxxxxxxxxxxx]

Evan Huus changed bug 9072

What	Removed	Added
Attachment #11452 Flags	review_for_checkin?	review_for_checkin-

Comment # 11 on bug 9072 from Evan Huus

Comment on attachment 11452 [details]
enhancement of packet-mq (+ new file packet-mq-base.c)

Thanks for the patch - I have taken a look through and I have a few questions
and concerns:

- You modify several core files (proto.c, except.c) in the patch as well. If
you need to implement additional features here for your dissector, please
attach them as a separate patch to the same bug, so they can be reviewed and
checked in separately.

- When you modify epan/dissectors/Makefile.common please also modify
epan/CMakeLists.txt. Also be sure that you are using the correct mix of tabs
and spaces in these files (your modification to Makefile.common did not align
on my system).

- A few small pieces of the patch no longer apply due to bug fixes that have
been applied in the meantime.

- It's hard to tell from a patch how much of this is leftover from the old
dissector and how much you've changed, but when writing new code please always
use the modern APIs: wmem instead of emem for memory management (see
docs/README.wmem) and filterable tree items (proto_tree_add_item,
expert_add_info) instead of unfilterable text.

Thanks,
Evan

---

      You are receiving this mail because:

• You are watching all bug changes.