Wireshark-bugs: [Wireshark-bugs] [Bug 9078] Buildbot crash output: fuzz-2013-08-26-30972.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 04 Sep 2013 20:38:48 +0000

Comment # 3 on bug 9078 from 
(In reply to comment #2)
> (In reply to comment #1)
> > I'm not sure this is really a bug, and I'm tempted to remove the assertion.
> > In this case it seems that the dissector is doing the right thing, and the
> > tree should just handle a key that long...
> > 
> > Thoughts anyone?
> 
> If there is no constraint on the max key size in the tree code management,
> then yes we should remove the assert.

There is no firm constraint, but it becomes terribly inefficient. Every 4 bytes
of key requires traversing another layer of the tree (in other words, the
height of the tree scales with the length of the key *and* the number of
elements). That's a poor way to do things really, but it's tightly baked into
the way the *_array32 functions work and would require a major API change to
fix.

You are receiving this mail because:
  • You are watching all bug changes.