Wireshark-bugs: [Wireshark-bugs] [Bug 9094] Wireshark should have a macsec dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 03 Sep 2013 11:57:39 +0000

changed bug 9094

What Removed Added
Attachment #11491 Flags review_for_checkin? review_for_checkin-

Comment # 4 on bug 9094 from 
Comment on attachment 11491 [details]
A patch which adds a MACsec dissector form MACsec

Looks good, but some minor issues:

1. Dissector doesn't have any preferences, so why include prefs.h?
2. Both FT_ETHER and FT_BYTES types can be used with proto_tree_add_item (use
encoding ENC_NA), so you don't have to use tvb_get_ptr.

You are receiving this mail because:
  • You are watching all bug changes.