Wireshark-bugs: [Wireshark-bugs] [Bug 9055] Support for bitmask set for types FT_INT8, FT_INT16,
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 24 Aug 2013 16:14:13 +0000

changed bug 9055

What Removed Added
Status UNCONFIRMED CONFIRMED
CC   eapache@gmail.com
Ever confirmed   1

Comment # 4 on bug 9055 from 
This looks good to me. I would prefer to make the sign-extension code you stole
from add_bits_ret_val a macro so that it's clearer what it's doing due to the
macro name.

Also, if you're going to use SWAR it should almost certainly go in wsutils
instead of embedding it in proto.c. A comment linking to an explanation
(http://playingwithpointers.com/swar.html is a good one) would probably be
worth-while as well.

Cheers,
Evan

You are receiving this mail because:
  • You are watching all bug changes.