Wireshark-bugs: [Wireshark-bugs] [Bug 9045] openSAFETY: Fixing heuristic detection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 19 Aug 2013 20:29:16 +0000

Comment # 4 on bug 9045 from 
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Comment on attachment 11390 [details]
> > > openSAFETY: Fixing heuristic detection
> > > 
> > > Committed to rev 51408 with some minor whitespace changes.
> > > 
> > > Should this be backported?  It appears the new CRC checks are post-1.10
> > > release.
> > 
> > If you backport this to 1.10, I would only backport the findSafetyFrame
> > function excluding the check for 0x5935 (as this would also need a change in
> > wsutil). 
> > 
> > If you also include my changes to wsutil/crc16.? then you can backport
> > findSafetyFrame as a whole.
> > 
> > This would suffice to fix the biggest issues with dissection in the current
> > 1.10. 
> > 
> > Should I prepare and test a patch against the current 1.10 master?
> 
> It's starting to sound complicated enough that it shouldn't be backported,
> but I'm open to other opinions.

That is the reason, that I did not supply the backport. People use the nightly
builds.

You are receiving this mail because:
  • You are watching all bug changes.